Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTEMS Serial Transport support #297

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Conversation

roncapat
Copy link
Contributor

@roncapat roncapat commented Dec 3, 2021

Following #283 and #287, made a rapid patch for serial transport support.
Tested with PingPong app as usual.

Details about how to test this transport using QEMU will be added in micro-ROS/micro_ros_setup#397 tracker issue.

Note: as for TCP/UDP, this patch implements a variant of POSIX transports using select() call instead of poll() call, which is not officially supported by RTEMS 5 core. Even if RTEMS-libBSD adds some poll() support, many boards (BSPs) would be potentially excluded from microROS usage due to inability to build libBSD for them.

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9
Copy link
Member

pablogs9 commented Dec 9, 2021

Can you rebase this onto develop and make this PR target develop?

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
@roncapat roncapat changed the base branch from master to develop December 9, 2021 18:20
@roncapat
Copy link
Contributor Author

roncapat commented Dec 9, 2021

@pablogs9 done. Poll me if I have messed up something in the process.

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Acuadros95 S&M if you are ok

@Acuadros95 Acuadros95 merged commit 7947f5b into eProsima:develop Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants