Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom GitHub Actions workflow to run tests with Python 3.6 in Ubuntu 20.04 container #4790

Open
wants to merge 1 commit into
base: 5.0.x
Choose a base branch
from

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 4, 2025

No description provided.


jobs:
test_python36:
runs-on: ubuntu-22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other projects I found it a good idea to use ubuntu-latest for all jobs using containers.

Suggested change
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

@Flamefire
Copy link
Contributor

I also started working on the before in #4789 using the Python versions available from the action I also opened an issue with them to support Python 3.6 on Ubuntu 22+

I also had to remove a job that you might want to add here:

          # There may be encoding errors in Python 3 which are hidden when an UTF-8 encoding is set
          # Hence run the tests (again) with LC_ALL=C and Python 3.6 (or any < 3.7)
          - python: 3.6
            modules_tool: ${{needs.setup.outputs.lmod8}}
            lc_all: C

@Flamefire
Copy link
Contributor

I added PRs for all repos to remove or replace the Ubuntu 20.04 runners:

It also needs updating of the required PR-CI tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants