Modernize method binding patterns in OpenTracesWidget #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes 'react-tooltip' dependency and adds an in-house tooltip impl. Simplifies the rendering of tooltips inside of all available views. Fixes some UI bugs with tooltips. Fixes the bugged hourglass bug. Signed-off-by: Will Yang <william.yang@ericsson.com>
Remove redundant method delegation patterns and explicit .bind(this) usage in favor of arrow functions. This modernization aligns with TypeScript best practices and reduces unnecessary code complexity while maintaining identical functionality. Changes: Replace method delegation pattern with direct arrow function implementation Remove explicit .bind(this) calls where arrow functions are used Maintain existing behavior and functionality Improve code readability Related to eclipse-cdt-cloud#1173 Signed-off-by: Will Yang <william.yang@ericsson.com>
|
Accidentally created this branch off of a feature branch. Deleting and creating a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Modernizes method binding patterns in OpenedTracesWidget as part of #1173 .
How to test
.bind(this)calls have been replaced with arrow functionsFollow-ups
No technical debt introduced. This PR reduces existing technical debt by simplifying the codebase.
Review checklist