Use JSONBigUtils of tsp-typescript-client for vscode messages #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
force-pushed
the
serializationTool-messenger-normalizer
branch
2 times, most recently
from
7ed74ac to
3c8eac7
Compare
...ension/src/trace-explorer/available-views/trace-explorer-available-views-webview-provider.ts
Outdated
Show resolved
Hide resolved
|
From what I see, after this PR, the code in this repo does not use the |
vscode-trace-webviews/src/trace-explorer/time-range/vscode-time-range-data-widget.tsx
Outdated
Show resolved
Hide resolved
vscode-trace-webviews/src/trace-viewer/vscode-trace-viewer-container.tsx
Outdated
Show resolved
Hide resolved
|
Very nice change! I have a few minor comments and I want to test it some more. |
Done |
bhufmann
force-pushed
the
serializationTool-messenger-normalizer
branch
2 times, most recently
from
a40dde1 to
8c8c067
Compare
bhufmann
force-pushed
the
serializationTool-messenger-normalizer
branch
from
8c8c067 to
2d901f4
Compare
Take advantage of Normalizer concept to take care of bigint values in data structures. Re-use of Normalizer implementations of the tsp-typescript-client, e.g. Experiment. Remove of vscode-signal-converter.ts since it's obsolete. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
serializationTool-messenger-normalizer
branch
from
2d901f4 to
e6c2074
Compare
marcdumais-work
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Take advantage of
Normalizerconcept to take care ofbigintvalues in data structures. Re-use of existingNormalizerimplementations of thetsp-typescript-client, e.g.Experiment.Remove of vscode-signal-converter.ts since it's obsolete.
Requires eclipse-cdt-cloud/tsp-typescript-client#56 to be deployed to NPM.
traceviewer-baseandtraceviewer-react-componentsNPM packages oftheia-trace-extensionupgraded and deployed to NPM as well.How to test
Successful CI. Verify that application works as before.
Follow-ups
No follow-ups at this point.
Review checklist
Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com