chore: add channel to rust-toolchain #43
Conversation
The current approach was failing on Windows machines due to possible CRLF issues. The change in the rust-toolchain file allows now to correctly use the provided channel by the rust toolchain without the override command
Updating CI pipeline to read out the value of the channel key
There was a problem hiding this comment.
We might as well use this opportunity to get rid of the legacy name rust-toolchain and rename to rust-toolchain.toml (since we changed the format to TOML). From the docs:
In these cases the toolchain can be named in the project's directory in a file called rust-
toolchain.tomlorrust-toolchain. If both files are present in a directory, the latter is used for backwards compatibility.For backwards compatibility,
rust-toolchainfiles also support a legacy format that only contains a toolchain name without any TOML encoding, …
As suggested in the PR review renaming rust-toolchain and adjusting corresponding usage
This reverts commit 101b46f. It seems that action-rs/toolchain doesn't support .toml as extension for rust-toolchain files
Update triggers to run pipelines when rust-toolchain updates
Yes, this is an open issue, but do we really need a whole action just to run |
As the github-action is not leveraging the toml format of the rust toolchain, reverting back to the rust-toolchain old format. Still override is removed from the dockerfile as it doesn't need to be explicitly called in order to use the toolchain provided in the file.
This reverts commit 101b46f.
Using now rustup show instead of the dedicated action-rs/toolchain github action. This allows using the .toml extension. Thanks @atifaziz for pointing out actions-rs/toolchain#126 (comment)
Yes, I agree. I updated this in 6d476ae |
Replaced the remaining github action commands for the rust toolchain.
Fixes #42
Description
The current approach was failing on Windows machines due to possible CRLF issues. The change in the rust-toolchain file allows now to correctly use the provided channel by the rust toolchain without the override command