Skip to content
This repository was archived by the owner on Aug 16, 2024. It is now read-only.

fix: update java mysql devfile #454

Merged
merged 2 commits into from
Jul 28, 2021
Merged

fix: update java mysql devfile #454

merged 2 commits into from
Jul 28, 2021

Conversation

vitaliy-guliy
Copy link
Contributor

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@svor svor changed the title Fix java mysql sample fix: update java mysql devfile Jul 26, 2021
@svor svor mentioned this pull request Jul 27, 2021
34 tasks
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

screenshot-che-eclipse-che 192 168 49 2 nip io-2021 07 27-09_53_31

@svor svor merged commit 89dbfcb into main Jul 28, 2021
@svor svor deleted the fix-java-mysql branch July 28, 2021 15:10
@che-bot che-bot added this to the 7.35 milestone Jul 28, 2021
@l0rd
Copy link
Contributor

l0rd commented Aug 3, 2021

Why have we switched to main branch? I am asking because in the past we moved to a specific commit instead of main/master branch to avoid that a devfile could be broken by newer commits.

@vitaliy-guliy
Copy link
Contributor Author

I think the devfile should be working, as we don't update our samples very often.
If it's preferred to use commit instead of a branch, we need to add that to all the devfiles. In most of them main/master or even default branch is used.
What shall we do?

@l0rd
Copy link
Contributor

l0rd commented Aug 5, 2021

I would suggest to use commits. In general it's safer to specify a commit or a tag rather than a branch. But that's not a top priority task so do it whenever you have the chance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants