Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Make Che Theia release script working on macOS #764

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Make Che Theia release script working on macOS #764

merged 1 commit into from
Jun 4, 2020

Conversation

azatsarynnyy
Copy link
Member

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

  1. Makes Che Theia release script working on macOS.
    To verify, run the similar command but with your Che Theia fork:
    ./make-release.sh --repo git@github.com:azatsarynnyy/che-theia --version 7.99.0 -t

  2. Makes Che Theia release script passing ShellCheck. Except for SC2086 as after applying it the script doesn't work right.

What issues does this PR fix or reference?

closes eclipse-che/che#16653
closes eclipse-che/che#16652

Release Notes

Docs PR

@azatsarynnyy
Make Che Theia release script working on macOS
3f430de 
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy azatsarynnyy requested a review from benoitf as a code owner June 2, 2020 16:49
@che-bot
Copy link
Contributor

che-bot commented Jun 2, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:764
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:764

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy
Copy link
Member Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 2, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:764
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:764

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

benoitf
benoitf approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@azatsarynnyy azatsarynnyy merged commit 168a544 into master Jun 4, 2020
@azatsarynnyy azatsarynnyy deleted the rel-script-fixes branch June 4, 2020 12:39
@azatsarynnyy azatsarynnyy mentioned this pull request Jun 5, 2020
Closed
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benoitf benoitf benoitf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Che Theia release script working on macOS Make Che Theia release script passing ShellCheck
3 participants
@azatsarynnyy @che-bot @benoitf