build: get version from inputs not from the starting event #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
approved these changes
Apr 15, 2024
paullatzelsperger
approved these changes
Apr 15, 2024
| @@ -16,8 +16,8 @@ jobs: | |||
| - uses: eclipse-edc/.github/.github/actions/setup-build@main | |||
|
|
|||
| - name: Override version if input is set | |||
| if: "${{ github.event.inputs.version != '' }}" | |||
| run: sed -i "s/version=.*/version=${{ github.event.inputs.version }}/g" gradle.properties | |||
| if: "${{ inputs.version != '' }}" | |||
There was a problem hiding this comment.
how about:
Suggested change
| if: "${{ inputs.version != '' }}" | |
| if: "${{ inputs.version != '' || github.event.inputs.version != '' }}" |
that way it'll fallback to the event's version input if the workflow input is not set
There was a problem hiding this comment.
I think it's not needed, this flow can only start from a workflow_call, so the inputs.version is the real source of trouth.
Checking the original event would add additional complexity because then we'll need to chose which one will be used in the sed command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
According to the documentation, the
github.eventrefers to the event that started the caller workflow, insteadinputsrefers to the actual parameters passedWhy it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.