Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsp: remove checksum from ContractNegotiation #2982

Closed
juliapampus opened this issue May 12, 2023 · 0 comments · Fixed by #2984
Closed

dsp: remove checksum from ContractNegotiation #2982

juliapampus opened this issue May 12, 2023 · 0 comments · Fixed by #2984
Assignees
@juliapampus
Labels
refactoring Cleaning up code and dependencies
Milestone
Milestone 9

Comments

@juliapampus
Copy link
Contributor

juliapampus commented May 12, 2023 •
edited
Loading

Feature Request

With the negotiation transformers, checksum has been introduced. This should be removed as it is not used.

Which Areas Would Be Affected?

contract negotiation

Why Is the Feature Desired?

Aligning with the updated protocol spec, this value will not be used within any dsp module. International-Data-Spaces-Association/ids-specification#99. Remove for clean up.

Solution Proposal

Remove property.
@juliapampus juliapampus added the refactoring Cleaning up code and dependencies label May 12, 2023
@juliapampus juliapampus added this to the Milestone 9 milestone May 12, 2023
@juliapampus juliapampus self-assigned this May 12, 2023
@juliapampus juliapampus mentioned this issue May 12, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliapampus juliapampus

Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
Milestone 9
Development

Successfully merging a pull request may close this issue.

chore: remove checksum from ContractNegotiation FraunhoferISST/edc-connector
1 participant
@juliapampus