Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove checksum from ContractNegotiation and correlating messages #99

Merged
merged 3 commits into from
May 15, 2023
Merged

fix: remove checksum from ContractNegotiation and correlating messages #99

merged 3 commits into from
May 15, 2023

Conversation

juliapampus
Copy link
Contributor

Closes #91

@juliapampus juliapampus changed the title refactor: remove checksum from ContractNegotiation fix: remove checksum from ContractNegotiation May 10, 2023
@matgnt
Copy link
Collaborator

matgnt commented May 12, 2023

Hi @juliapampus should we fix all 'checksum' appearances in a single commit? I found a few more matches:

negotiation/contract.negotiation.binding.https.md
negotiation/message/shape/contract-negotiation-event-message-shape.ttl
negotiation/message/shape/contract-offer-message-shape.ttl
negotiation/message/shape/contract-negotiation-shape.ttl
negotiation/message/diagram/contract-offer-message.puml
negotiation/message/diagram/contract-negotiation-event-message.puml
negotiation/message/contract-offer-message.json
negotiation/message/contract-negotiation.json
negotiation/message/schema/contract-negotiation-event-message-schema.json
negotiation/message/schema/contract-offer-message-schema.json
negotiation/message/contract-negotiation-event-message.json

@juliapampus
Copy link
Contributor Author

ah so it was intended to remove checksum at all? I wasn't aware of that. Will update

@matgnt
Copy link
Collaborator

matgnt commented May 12, 2023

That was my understanding, yes. Right, @jimmarino

Or if not, it should be documented somewhere what it is used for.

@juliapampus juliapampus mentioned this pull request May 12, 2023
Closed
@juliapampus juliapampus changed the title fix: remove checksum from ContractNegotiation fix: remove checksum from ContractNegotiation and correlating messages May 12, 2023
@juliapampus juliapampus force-pushed the chore/91_remove_checksum branch from 732e329 to 6be0d8a Compare May 12, 2023 10:34
@juliapampus juliapampus requested review from jimmarino and matgnt May 12, 2023 10:34
@juliapampus juliapampus merged commit 4a48935 into main May 15, 2023
@juliapampus juliapampus deleted the chore/91_remove_checksum branch May 15, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmarino jimmarino jimmarino approved these changes

@sebbader-sap sebbader-sap Awaiting requested review from sebbader-sap

@matgnt matgnt Awaiting requested review from matgnt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dspace:checksum seems to be not explained anywhere int the spec
3 participants
@juliapampus @matgnt @jimmarino