refactor: introduce null checks in manager #2816
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
==========================================
- Coverage 66.11% 66.07% -0.05%
==========================================
Files 999 999
Lines 20200 20176 -24
Branches 1181 1181
==========================================
- Hits 13355 13331 -24
Misses 6356 6356
Partials 489 489
☔ View full report in Codecov by Sentry. |
...rc/test/java/org/eclipse/edc/connector/transfer/transfer/TransferProcessManagerImplTest.java
Show resolved
Hide resolved
...ore/src/main/java/org/eclipse/edc/connector/transfer/process/TransferProcessManagerImpl.java
Outdated
Show resolved
Hide resolved
...pse/edc/connector/provision/azure/blob/ObjectStorageConsumerResourceDefinitionGenerator.java
Outdated
Show resolved
Hide resolved
...edc/connector/provision/azure/blob/ObjectStorageConsumerResourceDefinitionGeneratorTest.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/edc/connector/provision/gcp/GcsConsumerResourceDefinitionGenerator.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/edc/connector/provision/gcp/GcsConsumerResourceDefinitionGeneratorTest.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/edc/connector/service/transferprocess/TransferProcessEventDispatchTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lallu Anthoor <lallu.anthoor@sap.com>
lanthoor
force-pushed
the
refactor/null-check-in-managers
branch
from
572e83e to
5a51473
Compare
lanthoor
force-pushed
the
refactor/null-check-in-managers
branch
from
5a51473 to
a3b3562
Compare
|
@ndr-brt @jimmarino I need a bit more time to cleanup the other manager. I will set the PR to "Ready for review" once done. Thank you for your reviews. |
|
Could not find anything to refactor in |
|
@lanthoor Please mark the comments as resolved and we can approve once done. Thx |
|
@jimmarino done |
|
@jimmarino I do not have edit rights to the repo. Could you add the label |
|
@lanthoor thanks! |
* refactor: null check in TransferProcessManager Signed-off-by: Lallu Anthoor <lallu.anthoor@sap.com> * review comments --------- Signed-off-by: Lallu Anthoor <lallu.anthoor@sap.com>
* refactor: null check in TransferProcessManager Signed-off-by: Lallu Anthoor <lallu.anthoor@sap.com> * review comments --------- Signed-off-by: Lallu Anthoor <lallu.anthoor@sap.com>
What this PR changes/adds
policyinTransferProcessManagerWhy it does that
To avoid redundant null checks from collaborators of the managers.
Further notes
N/A
Linked Issue(s)
Closes #2225
Checklist
no-changelog)