fix: handle fatal errors in dsp http dispatcher delegate #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
bug
ndr-brt
requested review from
paullatzelsperger,
bscholtes1A,
ronjaquensel,
juliapampus and
jimmarino
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @param message the message | ||
| * @return a future that can be used to retrieve the response when the operation has completed | ||
| */ | ||
| <T, M extends RemoteMessage> CompletableFuture<StatusResult<T>> dispatch(Class<T> responseType, M message); |
Check notice
Code scanning / CodeQL
Useless parameter
ndr-brt
force-pushed
the
3202-handle-message-failure
branch
from
a05c604 to
63f4526
Compare
ndr-brt
commented
Jun 20, 2023
| } | ||
|
|
||
| @Nullable | ||
| private RemoteMessageDispatcher getDispatcher(@Nullable String protocol) { | ||
| if (protocol == null) { |
There was a problem hiding this comment.
I removed this fallback dispatcher because I couldn't see its usefulness
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
+ Coverage 65.59% 65.64% +0.04%
==========================================
Files 836 841 +5
Lines 16811 16872 +61
Branches 926 928 +2
==========================================
+ Hits 11028 11075 +47
- Misses 5415 5428 +13
- Partials 368 369 +1
☔ View full report in Codecov by Sentry. |
ndr-brt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add a new
dispatchmethod on bothRemoteMessageDispatcherandRemoteMessageDispatcherRegistrythat returnStatusResult, doing this it has been possible catchFATAL_ERRORs and avoid retryWhy it does that
avoid network pollution, improve error messaging
Further notes
From bottom to top:
handleResponsemethod inDspHttpDispatcherDelegatethat takes the place ofparseResponse. It takes care to look at the status code and create theStatusResultaccordingly, if response is successful, callparseResponse(that became protected)AsyncStatusResultRetryProcessclass, that extendsCompletableFutureRetryProcessand usesStatusResultRetryProcessto handle theStatusResultwhen the future succeeds.sendmethods onRemoteMessageDispatcherandRemoteMessageDispatcherRegistryare now unused, but I left them there to avoid compilation errors on downstream projects.Linked Issue(s)
Closes #3202
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.