Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): use release version in bump-job #3207

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Jun 21, 2023

What this PR changes/adds

This PR modifies the bump-version action and takes the release version (base version) from an action input and only falls back to the gradle.properties if that input was null.

Why it does that

when releasing e.g. 0.2.0, the next snapshot is supposed to be 0.2.1-SNAPSHOT.

Further notes

  • I also improved the snapshot patch version increment, so that when releasing versions with metadata, e.g. 0.3.6-rc2, the next snapshot version will still be 0.3.6-SNAPSHOT.
  • once this PR is approved, i'll do the same thing in all other repos as well.

Linked Issue(s)

Closes #3198

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger force-pushed the feature/feed_release_version_into_bump_job branch from 8624422 to 7faf220 Compare June 21, 2023 11:48
@paullatzelsperger paullatzelsperger added enhancement New feature or request build Anything related to the CI/CD Pipeline on Github Actions github_actions Pull requests that update GitHub Actions code labels Jun 21, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (176aedd) 65.64% compared to head (78f86e1) 65.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3207   +/-   ##
=======================================
  Coverage   65.64%   65.64%           
=======================================
  Files         841      841           
  Lines       16872    16872           
  Branches      928      928           
=======================================
  Hits        11075    11075           
  Misses       5428     5428           
  Partials      369      369           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paullatzelsperger paullatzelsperger merged commit f4d18e5 into eclipse-edc:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything related to the CI/CD Pipeline on Github Actions enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: feed the release version into the version-bump job
4 participants