Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add dependency check to CI workflow #3276

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Jul 6, 2023

What this PR changes/adds

  • Introduces a dedicated DEPENDENCIES file, which is referenced from NOTICE.md to enable easy automatic processing
  • Adds a CI check that verifies, that the DEPENDENCIES file is still up to date.

Whenever there is a new dependency, or a new version of an existing dependency, the DEPENDENCIES file must be regenerated. If the dependency is not yet reviewed, an IPLab issue must be opened, to get an approved status. This should be done manually.
If there is a rejected dependency, the CI job will fail.

Why it does that

EF requirements

Further notes

  • no automatic IPlap issues are generated
  • @juliapampus this job could be another candidate to be moved to the .github repo

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added documentation Improvements or additions to documentation enhancement New feature or request build Anything related to the CI/CD Pipeline on Github Actions labels Jul 6, 2023
@paullatzelsperger paullatzelsperger force-pushed the chore/update_dependencies_and_notice branch from 300f12d to 9cabe63 Compare July 6, 2023 05:33
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a96918e) 66.06% compared to head (5341960) 66.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3276   +/-   ##
=======================================
  Coverage   66.06%   66.06%           
=======================================
  Files         843      843           
  Lines       16937    16937           
  Branches      938      938           
=======================================
  Hits        11190    11190           
  Misses       5377     5377           
  Partials      370      370           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paullatzelsperger paullatzelsperger force-pushed the chore/update_dependencies_and_notice branch from 0b346e5 to 8a88124 Compare July 6, 2023 06:33
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

@paullatzelsperger
Copy link
Member Author

still waiting for some IPlab approvals. Once they are in, i'll update the PR and move to review.

@paullatzelsperger paullatzelsperger force-pushed the chore/update_dependencies_and_notice branch from 4c8f694 to 5341960 Compare July 6, 2023 07:37
@paullatzelsperger paullatzelsperger force-pushed the chore/update_dependencies_and_notice branch 3 times, most recently from 35af1fe to 0012457 Compare July 7, 2023 06:00
@paullatzelsperger paullatzelsperger marked this pull request as ready for review July 7, 2023 06:05
@paullatzelsperger paullatzelsperger force-pushed the chore/update_dependencies_and_notice branch from 0012457 to eaed861 Compare July 7, 2023 06:16
@paullatzelsperger paullatzelsperger merged commit 60957b2 into eclipse-edc:main Jul 7, 2023
bjungs pushed a commit to imec-int/edc that referenced this pull request Aug 18, 2023
* feat(build): add dependency check to CI workflow

* removed script, updated docs

* update

* moved dependency checks to its own workflow

* approvals of some libs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything related to the CI/CD Pipeline on Github Actions documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants