-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fixtures for end-to-end transfer tests #3285
feat: Add fixtures for end-to-end transfer tests #3285
Conversation
fa1402c
to
9fc7fef
Compare
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
=======================================
Coverage 72.41% 72.41%
=======================================
Files 843 843
Lines 17039 17039
Branches 949 949
=======================================
Hits 12339 12339
Misses 4306 4306
Partials 394 394 ☔ View full report in Codecov by Sentry. |
73dd7ac
to
cb4c78b
Compare
...est-fixtures/src/testFixtures/java/org/eclipse/edc/test/system/utils/TransferTestRunner.java
Outdated
Show resolved
Hide resolved
...est-fixtures/src/testFixtures/java/org/eclipse/edc/test/system/utils/TransferTestRunner.java
Outdated
Show resolved
Hide resolved
0cbd715
to
96a59c2
Compare
@@ -0,0 +1,33 @@ | |||
/* | |||
* Copyright (c) 2022 Microsoft Corporation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think this is. This file was initially in the testFixtures/tests
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Add fixtures for end-to-end transfer tests * Code review
What this PR changes/adds
Introduce helpers for testing end-to-end transfers.
Why it does that
Ease end-to-end testing in downstream repositories.
Linked Issue(s)
Closes #3282
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.