Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add fixtures for end-to-end transfer tests #3285

Merged

Conversation

bscholtes1A
Copy link
Contributor

What this PR changes/adds

Introduce helpers for testing end-to-end transfers.

Why it does that

Ease end-to-end testing in downstream repositories.

Linked Issue(s)

Closes #3282

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@bscholtes1A bscholtes1A added the enhancement New feature or request label Jul 7, 2023
@bscholtes1A bscholtes1A requested a review from ndr-brt as a code owner July 7, 2023 15:34
@bscholtes1A bscholtes1A force-pushed the feat/3282-transfer_test_fixtures branch 2 times, most recently from fa1402c to 9fc7fef Compare July 7, 2023 15:58
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (60957b2) 72.41% compared to head (cb4c78b) 72.41%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3285   +/-   ##
=======================================
  Coverage   72.41%   72.41%           
=======================================
  Files         843      843           
  Lines       17039    17039           
  Branches      949      949           
=======================================
  Hits        12339    12339           
  Misses       4306     4306           
  Partials      394      394           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bscholtes1A bscholtes1A force-pushed the feat/3282-transfer_test_fixtures branch 7 times, most recently from 73dd7ac to cb4c78b Compare July 10, 2023 07:40
@bscholtes1A bscholtes1A requested a review from ndr-brt July 10, 2023 13:32
@bscholtes1A bscholtes1A force-pushed the feat/3282-transfer_test_fixtures branch from 0cbd715 to 96a59c2 Compare July 11, 2023 09:46
@@ -0,0 +1,33 @@
/*
* Copyright (c) 2022 Microsoft Corporation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think this is. This file was initially in the testFixtures/tests folder.

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bscholtes1A bscholtes1A merged commit 8bf8cb9 into eclipse-edc:main Jul 11, 2023
bjungs pushed a commit to imec-int/edc that referenced this pull request Aug 18, 2023
* Add fixtures for end-to-end transfer tests

* Code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the Participant in test fixtures
5 participants