Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adds unit test for the break-lease-on-started issue #3340

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adds a unit test to #3336

Why it does that

was forgotten previously

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3335

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Jul 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage: 82.87% and project coverage change: +0.15% 🎉

Comparison is base (fae312e) 71.97% compared to head (78e497d) 72.13%.
Report is 5 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
+ Coverage   71.97%   72.13%   +0.15%     
==========================================
  Files         810      809       -1     
  Lines       16616    16603      -13     
  Branches      967      958       -9     
==========================================
+ Hits        11960    11977      +17     
+ Misses       4253     4233      -20     
+ Partials      403      393      -10     
Files Changed Coverage Δ
...se/edc/connector/catalog/CatalogCoreExtension.java 0.00% <0.00%> (ø)
...onnector/ControlPlaneDefaultServicesExtension.java 0.00% <0.00%> (ø)
...c/web/jersey/mapper/UnexpectedExceptionMapper.java 100.00% <ø> (ø)
.../eclipse/edc/sql/translation/JsonFieldMapping.java 0.00% <0.00%> (ø)
.../connector/store/sql/assetindex/SqlAssetIndex.java 85.29% <ø> (+1.49%) ⬆️
...main/java/org/eclipse/edc/spi/query/Criterion.java 25.00% <0.00%> (-0.81%) ⬇️
...clipse/edc/sql/translation/TranslationMapping.java 86.66% <66.66%> (-0.84%) ⬇️
...defaults/storage/ReflectionBasedQueryResolver.java 84.00% <69.23%> (-16.00%) ⬇️
.../asset/CriterionToAssetPredicateConverterImpl.java 75.00% <75.00%> (ø)
...rg/eclipse/edc/util/reflection/ReflectionUtil.java 80.70% <78.26%> (+0.91%) ⬆️
... and 11 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 3437cfe into eclipse-edc:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransferProcessManager: Lease is never broken for STARTED processes on the PROVIDER side
3 participants