-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3 dataplane): Fix transfer of empty objects #417
Merged
+75
−141
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b9dfaa4
Fix: S3 directory logic on file upload.
bmg13 a975f89
Fix: S3 directory logic on file upload.
bmg13 64e84ca
fix S3DataSink allows part upload when part is 0 byte file
rafaelmag110 bce5f6a
Improved unit and integration tests.
rafaelmag110 326153e
Rename function for readability
rafaelmag110 e52cd56
Indentation
rafaelmag110 0f1a0ec
Added no such key test
rafaelmag110 628c084
Fix checkstyle.
bmg13 0730a0e
Account for nested folders
rafaelmag110 6f11324
Remove unused argument
rafaelmag110 62ef21a
use predicate instead of method
rafaelmag110 50cc04f
Update DEPENDENCIES
rafaelmag110 a6645ac
change predicate to class const
rafaelmag110 6a1d444
dependencies
rafaelmag110 900004a
Update DEPENDENCIES again
rafaelmag110 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
use predicate instead of method
commit 62ef21a588aef4808200177aade729b622607851
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be a class field or constant, so it won't be recreated each time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in a6645ac