Remove unused leftovers of WPF launcher in JNIBridge #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the equinox launcher for Windows WPF the native methods OleInitialize() and OleUninitialize() where introduced and only implemented in the native library available for Windows WPF [1]. But during the removal of the WPF launcher [2] these methods have not been removed. Since the native implementation is not available anymore these native methods cannot be used. [1] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=172367 [2] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=479180
HannesWell
force-pushed
the
remove-OLEInitialization
branch
from
e21d483 to
6001d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the equinox launcher for Windows WPF launcher the native methods OleInitialize() and OleUninitialize() where introduced that where only implemented in the native library available for Windows WPF, see Bug 172367 / 3cf8518. But during the removal of the WPF launcher in Bug 479180 / 121b7c5 these methods have not been removed.
Since the native implementation is not available anymore these native methods cannot be used.