Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for bundles/org.eclipse.equinox.p2.updatesite #732

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

eclipse-equinox-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-equinox-bot
Copy link
Contributor Author

eclipse-equinox-bot commented Mar 6, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.p2.updatesite/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From a62989dbb73b04ad265301518415060438e6db1f Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <equinox-bot@eclipse.org>
Date: Sun, 9 Mar 2025 03:24:43 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.equinox.p2.updatesite/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.p2.updatesite/META-INF/MANIFEST.MF
index d7e8bd25f..0789aff1c 100644
--- a/bundles/org.eclipse.equinox.p2.updatesite/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.p2.updatesite/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.equinox.p2.updatesite;singleton:=true
-Bundle-Version: 1.3.600.qualifier
+Bundle-Version: 1.3.700.qualifier
 Bundle-Activator: org.eclipse.equinox.internal.p2.updatesite.Activator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Mar 6, 2025

Test Results

  375 files  ±0    375 suites  ±0   43m 22s ⏱️ - 1m 5s
1 905 tests ±0  1 902 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 715 runs  ±0  6 706 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 7268704. ± Comparison against base commit eba65b6.

♻️ This comment has been updated with latest results.

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.updatesite branch from 0519e41 to 6f99331 Compare March 7, 2025 03:27
@laeubi laeubi force-pushed the clean-code/bundles/org.eclipse.equinox.p2.updatesite branch from a4a24bc to 6ff586e Compare March 7, 2025 08:05
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.updatesite branch from 6ff586e to e446cb3 Compare March 8, 2025 03:08
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.updatesite branch from 333a736 to dbd556f Compare March 9, 2025 03:21
Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@laeubi laeubi merged commit a4ef0e1 into master Mar 9, 2025
12 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.equinox.p2.updatesite branch March 9, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants