Cleanup samples output #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wilyle
reviewed
Mar 29, 2023
samples/command/consumer/src/main.rs
Outdated
| @@ -28,6 +31,10 @@ fn start_show_notification_repeater(provider_uri: String, consumer_uri: String) | |||
| debug!("Starting the Consumer's show notification repeater."); | |||
| tokio::spawn(async move { | |||
| loop { | |||
| let payload: String = String::from("The show-notification request."); | |||
|
|
|||
| info!("Sending an invoke request on entity {} with payload '{payload} to provider URI {provider_uri}", sdv::vehicle::cabin::infotainment::hmi::show_notification::ID,); | |||
There was a problem hiding this comment.
this should maybe be formatted with a new line, and the trailing comma looks strange here too
There was a problem hiding this comment.
I fixed the comma. I will let cargo fmt decide when to wrap lines.
samples/command/consumer/src/main.rs
Outdated
|
|
||
| // Obtain the DTDL for the send_notification command. | ||
| info!("Sending a find_by_id request to the Digital Twin Service for the DTDL for the send_notification command."); | ||
| let mut client = DigitalTwinClient::connect("http://[::1]:50010").await?; // Devskim: ignore DS137138 | ||
| info!("Sending a find_by_id request for entity id {} to the In-Vehicle Digital Twin Service URI {IN_VEHICLE_DIGITAL_TWIN_SERVICE_URI}", sdv::vehicle::cabin::infotainment::hmi::show_notification::ID); |
There was a problem hiding this comment.
i would also suggest a new line here
There was a problem hiding this comment.
I think that it is fine.
| @@ -127,7 +133,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| let provider_uri = String::from(uri_str_option.unwrap()); | |||
| info!("The URI for the show-notification command's provider is {provider_uri}"); | |||
|
|
|||
| let consumer_uri = format!("http://{consumer_authority}"); // Devskim: ignore DS137138 | |||
| let consumer_uri = format!("http://{CONSUMER_ADDR}"); // Devskim: ignore DS137138 | |||
There was a problem hiding this comment.
do we still need the devskim comment here?
There was a problem hiding this comment.
We do when it is accompanied by a "http://".
samples/mixed/consumer/src/main.rs
Outdated
| @@ -28,6 +32,10 @@ fn start_show_notification_repeater(provider_uri: String, consumer_uri: String) | |||
| debug!("Starting the Consumer's show-notification repeater."); | |||
| tokio::spawn(async move { | |||
| loop { | |||
| let payload: String = String::from("show-notification request"); | |||
|
|
|||
| info!("Sending an invoke request on entity {} with payload '{payload} to provider URI {provider_uri}", sdv::vehicle::cabin::infotainment::hmi::show_notification::ID,); | |||
mobicatk
pushed a commit
to Mobica/EclipseSDV_ibeji
that referenced
this pull request
Apr 24, 2024
* Cleanup samples output * Cleanup samples output * Cleanup samples output * Cleanup samples output * Cleanup samples output * Cleanup samples output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.