Chariott Service Discovery Integration #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashbeitz
commented
Jul 27, 2023
•
ashbeitz
commented
- Replaces Chariott's intent-based service discovery with its new simpler service discovery feature.
- Replaces the use of URL with URI.
- Make sure that we consistently refer to the in-vehicle digital twin interface (we sometimes refer to it as the digital twin interface).
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
ashbeitz
commented
Jul 27, 2023
jorchiu
reviewed
Jul 27, 2023
ladatz
reviewed
Jul 27, 2023
devkelley
reviewed
Jul 27, 2023
wilyle
reviewed
Jul 27, 2023
wilyle
approved these changes
Jul 27, 2023
jorchiu
approved these changes
Jul 27, 2023
mobicatk
pushed a commit
to Mobica/EclipseSDV_ibeji
that referenced
this pull request
Apr 24, 2024
* service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration * service discovery integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.