Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial for creating a vehicle model using DTDL and translating that to Rust code #66

Merged
merged 13 commits into from
Nov 7, 2023

Conversation

jorchiu
Copy link
Contributor

@jorchiu jorchiu commented Nov 6, 2023

This PR adds a tutorial in the ibeji/docs/tutorials directory for creating a vehicle model using DTDL and translating that to Rust code.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Please take a look.

Copy link
Contributor

@ladatz ladatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comments

jorchiu and others added 4 commits November 6, 2023 14:56
Co-authored-by: William Lyles <26171886+wilyle@users.noreply.github.com>
ashbeitz
ashbeitz previously approved these changes Nov 7, 2023
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

wilyle
wilyle previously approved these changes Nov 7, 2023
@jorchiu jorchiu dismissed stale reviews from wilyle and ashbeitz via 37f2336 November 7, 2023 18:47
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jorchiu jorchiu merged commit f2483de into main Nov 7, 2023
@jorchiu jorchiu deleted the jorchiu/tutorial_dtdl branch November 7, 2023 18:54
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants