Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation of std::span to iceoryx_hoofs #180

Closed
orecham opened this issue Jul 8, 2020 · 1 comment · Fixed by #1785
Closed

Add implementation of std::span to iceoryx_hoofs #180

orecham opened this issue Jul 8, 2020 · 1 comment · Fixed by #1785
Assignees
@patdhlk
Labels
enhancement New feature

Comments

@orecham
Copy link
Contributor

orecham commented Jul 8, 2020

Brief feature description

The std::span STL feature from C++20 will be useful for working with byte arrays in iceoryx.

Detailed information

See:

One use-case is for passing around pointers to byte arrays to a function.
Usually, some checks need to be done in the function to ensure the array is valid (i.e. nullptr check, size validation).
With std::span, all of this logic is done automatically and the function doesn't need to reimplement it.
@orecham orecham mentioned this issue Jul 8, 2020
Merged
@mossmaurice mossmaurice added the feature request Feature request under evaluation label Nov 2, 2020
@mossmaurice mossmaurice modified the milestone: v2.0 Nov 4, 2020
@mossmaurice mossmaurice changed the title Add implementation of std::span to iceoryx_utils Add implementation of std::span to iceoryx_hoofs Jun 9, 2022
@mossmaurice mossmaurice mentioned this issue Nov 3, 2022
Closed
@patdhlk
Copy link
Contributor

patdhlk commented Nov 4, 2022 •
edited
Loading

I'm working on it, I hope a fist version is available beginning next week

@mossmaurice mossmaurice added enhancement New feature and removed feature request Feature request under evaluation labels Nov 4, 2022
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 9, 2022
@patdhlk
iox-eclipse-iceoryx#180 Add std::span
0df7dd6
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 9, 2022
@patdhlk
iox-eclipse-iceoryx#180 Rename span iterator
6a99972
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 9, 2022
@patdhlk
iox-eclipse-iceoryx#180 Add std::span
82aa088
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 9, 2022
@patdhlk
iox-eclipse-iceoryx#180 Rename span iterator
20b19a9
@patdhlk patdhlk mentioned this issue Nov 10, 2022
Merged
21 tasks
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 10, 2022
@patdhlk
iox-eclipse-iceoryx#180 Formatted span test file
3b01431
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 10, 2022
@patdhlk
iox-eclipse-iceoryx#180 Formatted type_traits.hpp
b915f06
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 10, 2022
@patdhlk
iox-eclipse-iceoryx#180 Move implementation to *.inl file
0aea274
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 11, 2022
@patdhlk
iox-eclipse-iceoryx#180 Remove unrequired include, fix inconsistent n…
9273ee3 
…aming
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Nov 12, 2022
@patdhlk
iox-eclipse-iceoryx#180 Replace std::array with iox::UninitializedArray
e1f0161
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Dec 2, 2022
@patdhlk
iox-eclipse-iceoryx#180 Move implementations to inline file:
c3abb64 
- where it was possible
patdhlk added a commit to ApexAI/iceoryx that referenced this issue Dec 6, 2022
@patdhlk
iox-eclipse-iceoryx#180 Move span to iceoryx_dust
8b8c567
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Add std::span
055a396
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Rename span iterator
400cc0c
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Formatted span test file
6c31446
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Move implementation to *.inl file
fce3ffb
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Remove unrequired include, fix inconsistent n…
f13baca 
…aming
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Replace std::array with iox::UninitializedArray
bf316b7
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Move implementations to inline file:
9932db0 
- where it was possible
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 12, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Move span to iceoryx_dust
9e57133
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Replace std::array with iox::UninitializedArray
c1d0820
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Move implementations to inline file:
48914f3 
- where it was possible
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@patdhlk @mossmaurice-apexai
iox-eclipse-iceoryx#180 Move span to iceoryx_dust
3e9e506
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Move 'iox::span' into 'vocabulary' module
13e4f47 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Add release note entry for 'iox::span'
c50df00 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Fix compiler warnings about 'static_assert'
b2b84f3 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Add doxygen comments to 'iox::span'
ea49088 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Add doxygen comments to 'iox::span' and fix o…
a1b1b0f 
…ther review

findings

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 14, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Remove null-ability form 'iox::span'
0ebe3b3 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Fix Bazel and GCC5 build of 'iox::span'
7627919 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Remove 'make_span' helpers
cd502fd 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Remove unneeded include from 'iox::span'
8c89c69 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Add test cases using 'iox::UninitializedArray…
62981db 
…' with 'iox::span'

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Move implementation to '.inl' and create a se…
96cf9d7 
…parate type traits file

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address clang-tidy warnings
f3c2919 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address clang-tidy warnings
5737863 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address clang-tidy warnings
b6651a5 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Implement move operations for 'iox::span'
05e3970 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 17, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Implement move operations for 'iox::span'
ee3581f 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 18, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address review findings by fixing some doxyge…
25dbce9 
…n typo in 'iox::span' and moving 'std::size' to the respective header

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 18, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address review findings by removing superfluo…
56cf951 
…us 'std' in 'iox::span'

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 18, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address review findings by removing superfluo…
25b09bb 
…us 'std' in 'iox::span'

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 18, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address review findings by replacing some 'st…
5caa01f 
…atic_assert's with 'assert' and adding some new in 'iox::span'

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 19, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address review findings by replacing some 'st…
7f2dc41 
…atic_assert's with 'assert' and adding some new in 'iox::span'

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice pushed a commit to ApexAI/iceoryx that referenced this issue Apr 19, 2023
@mossmaurice-apexai
iox-eclipse-iceoryx#180 Address review findings by replacing some 'st…
522b5bd 
…atic_assert's with 'assert' and adding some new in 'iox::span'

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 24, 2023
@elBoberido
iox-eclipse-iceoryx#180 Fix link to AUTOSAR C++ guidelines
02f714f
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 24, 2023
@elBoberido
iox-eclipse-iceoryx#180 Skip constexpr test for gcc
9670c91
elBoberido added a commit to ApexAI/iceoryx that referenced this issue Apr 24, 2023
@elBoberido
iox-eclipse-iceoryx#180 Skip constexpr test for gcc
e93b7b5
mossmaurice pushed a commit that referenced this issue Apr 25, 2023
@mossmaurice-apexai
Merge pull request #1785 from ApexAI/iox-180-add-span-implementation
90996dc 
iox-#180 Add span implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patdhlk patdhlk

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-#180 Add span implementation ApexAI/iceoryx
3 participants
@orecham @mossmaurice @patdhlk