Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1391 Move list to container module #2061

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 25, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR moves the list from iceoryx_hoofs/cxx to iceoryx_hoofs/container and deprecates the old header for iceoryx v3.0.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Oct 25, 2023
@elBoberido elBoberido added the refactoring Refactor code without adding features label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2061 (f0e20a2) into master (b9b2c4a) will not change coverage.
Report is 21 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2061   +/-   ##
=======================================
  Coverage   74.44%   74.44%           
=======================================
  Files         417      417           
  Lines       15986    15986           
  Branches     2272     2272           
=======================================
  Hits        11900    11900           
  Misses       3304     3304           
  Partials      782      782           
Flag Coverage Δ
unittests 74.22% <ø> (ø)
unittests_timing 15.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ceoryx_hoofs/container/include/iox/detail/list.inl 91.23% <ø> (ø)
...de/iceoryx_posh/internal/roudi/process_manager.hpp 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

elfenpiff
elfenpiff previously approved these changes Oct 25, 2023
@mossmaurice mossmaurice self-requested a review October 25, 2023 21:10
mossmaurice
mossmaurice previously approved these changes Oct 25, 2023
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Base automatically changed from iox-2057-create-deprecation-macros to master October 25, 2023 21:22
@elBoberido elBoberido dismissed stale reviews from mossmaurice and elfenpiff October 25, 2023 21:22

The base branch was changed.

@elBoberido elBoberido merged commit 2a0be7b into master Oct 25, 2023
@elBoberido elBoberido deleted the iox-1391-move-list-to-container-module branch October 25, 2023 21:28
@elBoberido elBoberido changed the title [Stacked on #2059] iox-#1391 Move list to container module iox-#1391 Move list to container module Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants