Remove Service-Component OSGI-INF/*.xml from uber-jar

[merks]

#1731

[merks]

I ran the build locally and there is no such folder:

merks@CORE MINGW64 /d/Users/merks/temp/lemminx/org.eclipse.lemminx
$find . -name "*OSGI*"

merks@CORE MINGW64 /d/Users/merks/temp/lemminx/org.eclipse.lemminx

[mickaelistria]

@laeubi Can you please review?

[laeubi]

I ran the build locally and there is no such folder

please read the spec:

The last component of each path in the Service-Component header may use wildcards so that Bundle.findEntries can be used to locate the XML document within the bundle and its fragments.
For example:

Service-Component: OSGI-INF/*.xml

See also:

• [ds] Requirement to log an error is ambiguous osgi/osgi#789

so this is not an error but allows extension of the lemminx-uber jar provided with OSGi-Fragements, so this is not an error.

[merks]

Is it an error not to have it? What will no longer work without it? What is looking up what, where, and why? Is anyone actually using that capability or is this something that could exist but doesn't current actually exist?

Pretend that I am stupid and know nothing about this. Also imagine a million users coming to this issue who will be equally confused and that being told to please read the spec and/or please go complain somewhere about ambiguous logging specification will perhaps prove unsatisfying. They might shake their heads and ask "What's wrong with these people?" hypothetically speaking...

Or a different question, whomever is pulls this dependency into an installation, can they provide said fragment that will make the error stop logging? Or better yet, can the project itself provide a degenerate/no-op/empty XML file that will make it stop logging. Can we can do something/anything to that make something be located by the wildcard so that there is no error logged?

[laeubi]

Is it an error not to have it?

Of course not

What will no longer work without it?

You can no longer extend the bundle with fragments that contain declarative service components.

What is looking up what, where, and why?

https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#d0e30931

Is anyone actually using that capability or is this something that could exist but doesn't current actually exist?

As it was only added with the last release it could be used now but not before. e.g. m2e is providing an extension to lemminx now, for further details see:

• Do not embedd lemminx eclipse-wildwebdeveloper/wildwebdeveloper#1712

Pretend that I am stupid and know nothing about this. Also imagine a million users coming to this issue who will be equally confused and that being told to please read the spec and/or please go complain somewhere about ambiguous logging specification will perhaps prove unsatisfying. They might shake their heads and ask "What's wrong with these people?" hypothetically speaking...

This is really hypothetical as no one is actually looking at the Eclipse log (or no one really complains) as these are not errors that surface to the usual user, e.g. this is what I see in my daily eclipse (and I regularly clear the error log so it is only from the past days):

So did we get "million complains"? not really ... are people confused? not really... Does anyone work on these issue? I'm not sure ...

Can we can do something/anything to that make something be located by the wildcard so that there is no error logged?

Eclipse consumes https://github.com/apache/felix-dev/tree/master/scr what is the component that logs the error.

[merks]

Repeating different question... Whomever is pulls this dependency into an installation, can they provide said fragment that will make the error stop logging? Or better yet, can the project itself provide a degenerate/no-op/empty XML file that will make it stop logging? Can we can do something/anything now to that make something be located by the wildcard so that there is no error logged?

[laeubi]

I have created

• Do not print an error when a wildcard is used in component header apache/felix-dev#383

or better yet, can the project itself provide a degenerate/no-op/empty XML file that will make it stop logging?

Having something added as a workaround to suppress a harmless logmessage do not seems valuable to me. For the record an dummy, disabled by default component description will look like this:

<?xml version="1.0" encoding="UTF-8"?>
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" enabled="false" name="dummy">
   <!-- See https://github.com/apache/felix-dev/pull/383 -->
   <implementation class="java.lang.Object"/>
</scr:component>