Use GraalVM CPU architecture compatibility mode #1733
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents GraalVM from using CPU architecture extensions (for example, AVX and AVX2 for x86_64). This will increase the portability of the binary (i.e. it can be run on older CPUs that don't support those instructions). Docs for the setting: https://www.graalvm.org/latest/reference-manual/native-image/overview/Options/#build-options See redhat-developer/vscode-xml#1055 Signed-off-by: David Thompson <davthomp@redhat.com>
|
I've tested the generated binary using Helix and it works there. I also disassembled the binary and used the awk script here to look for AVX instructions: https://stackoverflow.com/a/50056059 ( I didn't find any ). |
|
@rgrunber if you have some time, do you mind looking over this? |
rgrunber
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Seems reasonable based on https://www.graalvm.org/latest/reference-manual/native-image/overview/Options/ . compatibility is probably what we wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents GraalVM from using CPU architecture extensions (for example, AVX and AVX2 for x86_64). This will increase the portability of the binary (i.e. it can be run on older CPUs that don't support those instructions).
Docs for the setting: https://www.graalvm.org/latest/reference-manual/native-image/overview/Options/#build-options
See redhat-developer/vscode-xml#1055