Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce qualifier update to pick-up JDT extension-point doc fixes #1209

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Jul 9, 2023

So that the changes from eclipse-jdt/eclipse.jdt.debug#278 are picked up to fix eclipse-platform/eclipse.platform#561.

@laeubi
Copy link
Contributor

laeubi commented Jul 9, 2023

Why don't bump the version instead?

@HannesWell
Copy link
Member Author

Why don't bump the version instead?

It already has been bump for the 4.29 stream.

@laeubi
Copy link
Contributor

laeubi commented Jul 9, 2023

Why don't bump the version instead?

It already has been bump for the 4.29 stream.

It is not forbidden to bump it more than once ;-)

@HannesWell
Copy link
Member Author

HannesWell commented Jul 9, 2023

It is not forbidden to bump it more than once ;-)

Yes, but personally I find it a bit odd, nevertheless there is no strong reason not to do it. But what's the disadvantage of using the forceQualifierUpdate.txt? I would say, that use cases like this are its purpose.

@HannesWell
Copy link
Member Author

Checking the build results (I replayed the build to include the jdt.doc.isv bundle) looks very promising. The leading space was gone in the html page. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure of LinkTest.testAllLinks()
2 participants