Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Unify 'natives' ant-script invocation into the binaries-parent #24

Merged

Conversation

HannesWell
Copy link
Member

Use the ant-contrib 'if' task to check if execution of the natives build is requested. This saves many duplicated profiles in each platform-specific fragment.

@HannesWell HannesWell requested a review from akurtakov December 7, 2022 21:13
Use the ant-contrib 'if' task to check if execution of the natives build
is requested. This saves many duplicated profiles in each
platform-specific fragment.
@akurtakov akurtakov force-pushed the unifyNativesBuildInvocation branch from 45f295c to bac707c Compare December 8, 2022 06:26
@akurtakov
Copy link
Member

Thanks @HannesWell ! This area badly needed some love.

@akurtakov akurtakov merged commit 207370e into eclipse-platform:master Dec 8, 2022
@HannesWell
Copy link
Member Author

Thanks @HannesWell ! This area badly needed some love.

Yes, and eclipse-platform/eclipse.platform.swt#490 is a good opportunity to give it some. :)

@HannesWell HannesWell deleted the unifyNativesBuildInvocation branch December 8, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants