Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Update the required Node.js version in the Prerequisites section #2880

Closed
kittaakos opened this issue Sep 14, 2018 · 4 comments
Closed

[doc] Update the required Node.js version in the Prerequisites section #2880

kittaakos opened this issue Sep 14, 2018 · 4 comments
Assignees
@kittaakos
Labels
documentation issues related to documentation

Comments

@kittaakos
Copy link
Contributor

No description provided.

@kittaakos kittaakos added the documentation issues related to documentation label Sep 14, 2018
@kittaakos kittaakos self-assigned this Sep 14, 2018
kittaakos added a commit that referenced this issue Sep 14, 2018
@kittaakos
GH-2880: Updated the required Node.js version.
17c2b89 
Closes: #2880.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@akosyakov
Copy link
Member

akosyakov commented Sep 14, 2018 •
edited
Loading

I wonder should we mention which Node.js version should be used to make sure that app works in Electron, i.e. developers should not use APIs of Node.js higher than a version compatible with Electron 1.8.2-beta.5. I don't think we can use 9, 10 in this case.

kittaakos added a commit that referenced this issue Sep 14, 2018
@kittaakos
GH-2880: Updated the required Node.js version.
383b578 
Closes: #2880.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Sep 14, 2018
Merged
@kittaakos
Copy link
Contributor Author

I do not know much about 9. But for sure we cannot use 10.

@kittaakos
Copy link
Contributor Author

But it is recommended to use a version that has the active LTS. Only the even version number has active LTS support: https://github.com/nodejs/Release.

@akosyakov
Copy link
Member

akosyakov commented Sep 14, 2018 •
edited
Loading

I mean in Electron always bundled Node.js is used, as far as I know, Node.js 9 and 10 only supported by Electron 3. If someone uses APIs from them his app/extension won't work in Electron.

@kittaakos kittaakos mentioned this issue Sep 17, 2018
Closed
kittaakos added a commit that referenced this issue Sep 17, 2018
@kittaakos
GH-2880: Updated the required Node.js version.
bc15a14 
Closes: #2880.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos added a commit that referenced this issue Sep 17, 2018
@kittaakos
GH-2880: Updated the required Node.js version.
6879ee7 
Closes: #2880.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
marcdumais-work pushed a commit to marcdumais-work/theia that referenced this issue Oct 15, 2018
@kittaakos @marcdumais-work
eclipse-theiaGH-2880: Updated the required Node.js version.
3adcca8 
Closes: eclipse-theia#2880.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
documentation issues related to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittaakos @akosyakov