Tests files should not be compiled with the theia code

[hexa00]

I think test files should be compiled only before the tests runs.

This would also allow tests that may depend on previously compiled code in the same package. Like the globalize PR needs to do.

Objections?

[svenefftinge]

I don't understand this request.
Do you want to recompile the code base before every test? Or what are test files?

[hexa00]

I mean we should not compile *.spec.ts when we compile theia with yarn.build
And rather compile spec.ts as we do yarn test

[svenefftinge]

Ok, why?

[hexa00]

In the case of the globalize PR you have like:

test.spec.ts
require(localize.ts);

generator.ts
fs.write(localize.ts)

And this package would be built with:
generate-localize.ts && build

So since the test requires localize.ts and that this is a generated file by the package it fails to compile.

We would need to compile the package, run the generator, then compile the test.

[hexa00]

I think also it will save time when we package theia, we don't need to build the tests then..

[svenefftinge]

why do we need to compile it first? I think it should be "generate, compile, test".

[hexa00]

Well the generator needs to be compiled...

[svenefftinge]

Ah, ok I didn't realize it is part of the runtime code. The generator should be in a separate package, actually being moved to dev-packages after #527 was merged. We should also have a CLI command for it.

[hexa00]

The problem in this case is that an extension dev may require that generator so it needs to be part of a proper package I think ? So it can be published etc ?

[svenefftinge]

Yes, that is the case with all our dev dependencies. And the cli exposes the tools to extension developers.

[hexa00]

OK So the dev-deps will be published ?

[svenefftinge]

Yes. Extension developers (and Theia packaging jobs) will pull the tools from npm.js.

[hexa00]

OK great then! :) We'll move it there

[vince-fugnitto]

I believe the issue can be successfully closed, most dev packages are published (except for `ext-scripts). Please feel free to re-open the issue if the issue is still relevant.