Get rid of package.json generation and yeoman generator

[akosyakov]

No description provided.

[akosyakov]

Just to clarify: we do it to streamline the setup of Theia itself as well as the setup for extension developers and simplify the dynamic extension system.

An extension developer will be able to create package.json using standard tools, like npm init, list extension packages and add @theia/cli as a dev dependency:
https://github.com/theia-ide/theia/blob/44f764c9f195364ace851e88772c6302adef06b1/examples/browser/package.json#L1-L35
After installing such package he will use theia cli tool to manage an application, see npm scripts above. So such command like npx theia browser --port=3001 --root-dir=/home/user/mydir or via npm script yarn start -- --port=3001 --root-dir=/home/user/mydir would be possible.

For the Theia setup, we won't need the package.json generation phase anymore that allows removing some build scripts, simplify root package.json, enable yarn workspaces.

[hexa00]

What is not supported by node 6 in this ?

[akosyakov]

@hexa00 async/await with pure js, bogus cluster module with node 6

[akosyakov]

LTS of node 8 should start in October: https://github.com/nodejs/Release#release-schedule1

[akosyakov]

I would like to merge it if no objections and go on with the dynamic extension system.

[akosyakov]

@hexa00 I've merged test:fast and test:slow in single test and adjusted pattern to cover all *.*spec.ts files that there is no special handling for the terminal package and everything is covered
https://github.com/theia-ide/theia/blob/e36aa557bf687ece15a95b44c64e671b57445ea8/dev-packages/ext-scripts/package.json#L26-L27

[hexa00]

I think the coverage gets merged.
OK for the merged tests if we can separate it when need be.

[akosyakov]

@hexa00 yeah, it would be a bit messy with dummy spec files, we should look for the better way generally

[hexa00]

@akosyakov Yes must be a way to treat warnings as warnings rather than errors

[hexa00]

Did you test the yarn.lock ?

[akosyakov]

@hexa00 I fixed the propagation of the error code broken tests should fail the build now

[hexa00]

Testing that now

[akosyakov]

@hexa00 nope, but should work, now lerna does not call install anymore, it is completely done by yarn

[hexa00]

Works fine , thanks! I need to increase that timeout

[hexa00]

Tested yarn.lock seems to work yeee!
(tested by using ^1.7.6 for electron)

[hexa00]

The log output is also so much easier to see!

[akosyakov]

I've merged theia-generator into the cli:

• there are no dependencies on yo and yeoman-generator anymore, it makes windows builds stable
• there are no yo configs, modules are discovered with require.resolve after installing
• webpack configs are regenerated each time and added to git ignore
• moved all dev dependencies to the root package, new should be added there as well

Please review.

[svenefftinge]

Looks really good. I would consider the generator to be part of the extension system, but we can move that in another PR.