Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virtuoso-dev from the license check baseline #11582

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 18, 2022

What it does

After #11553, we had to add virtuoso-dev to the license check baseline due to a minor issue in the license check tool. Wayne fixed the underlying issue (see here) and now we can remove it again.

How to test

The 3PP license check github action succeeds

Review checklist

Reminder for reviewers

@msujew msujew added the ci issues related to CI / tests label Aug 18, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@msujew msujew merged commit d27ebe7 into master Aug 18, 2022
@msujew msujew deleted the msujew/remove-virtuoso-dev branch August 18, 2022 12:14
@github-actions github-actions bot added this to the 1.29.0 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants