Disable cpp UI test on Windows #3365
Conversation
This test doesn't pass on AppVeyor, disable it on Windows to avoid blocking everything else. Change-Id: I193dc180e140c49ae23489fe3a2b3fa440654626 Signed-off-by: Simon Marchi <simon.marchi@ericsson.com>
|
Here's an example of build where it fails: https://ci.appveyor.com/project/kittaakos/theia/builds/19969799 I think we didn't see the failure in the AppVeyor run for the PR that merged this test: https://ci.appveyor.com/project/kittaakos/theia/builds/19954147 because of other intermittent failures in the non-UI tests. Actually, it seems like when there is a failure in the non-UI tests, UI tests don't get to run. In the build log, there is no mention of this test at all. If it had a chance to run then, it would probably have failed. |
|
@simark I think you forgot to sign the commit :( |
simark
force-pushed
the
carl_castonguay
branch
from
e08d4be to
19fe261
Compare
Updated. |
|
@simon Since the wait time is quite long for AppVeyor, maybe we can just wait until Travis CI passes for this PR? It should have no effect on other platforms than Windows. |
Yes, but let's wait at least until we are able to test it manually. |
|
Closed in favor of actually fixing the test, in #3370. |
|
It looks like it will take a bit of time to get #3370 in, so let's merge this one to stop make AppVeyor builds fails. @marcdumais-work or @marechal-p ? |
This test doesn't pass on AppVeyor, disable it on Windows to avoid
blocking everything else.
Change-Id: I193dc180e140c49ae23489fe3a2b3fa440654626