Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Extension System #391

Merged
merged 28 commits into from
Oct 12, 2017
Merged

Dynamic Extension System #391

merged 28 commits into from
Oct 12, 2017

Conversation

akosyakov
Copy link
Member

No description provided.

@akosyakov
Copy link
Member Author

akosyakov commented Aug 12, 2017 •
edited
Loading

@svenefftinge The following is not yet covered:

  • the progress of the installation is not displayed to the user but only logged, it depends on Process Output Window / Console View #49
  • the installation is failing if package.json has a dependency that should be symlinked with the local path because yarn always try to resolve all declared packages, we should probably have some intermediate package.json without such dependencies to call yarn - yarn/npm should be used
  • the transitive dependencies are not supported, see Support transitive extension packages #369
  • showing downloads count to the user - not critical
  • this PR contains as well [notifications] #185: added the simple message service #390 that should be merged before, I am not going to improve it since it is enough for this PR, someone else should provide the complete implementation
  • the search performance should be measured and optimized
  • I wanted to add the cli interface for ExtensionServer to fetch installed, outdated extensions, install, uninstall them, trigger the installation and so on, could be done later if at all - yarn/npm should be used
  • failure handling:
    • keeping package.json backup by date
    • rollback on failure
  • update README for the extension manager

@svenefftinge
Copy link
Contributor

svenefftinge commented Aug 18, 2017 •
edited
Loading

rebased the branch

@akosyakov akosyakov mentioned this pull request Aug 31, 2017
Closed
@akosyakov akosyakov force-pushed the jb/extension_ui branch 6 times, most recently from bc2c762 to 482ed16 Compare September 18, 2017 10:53
@akosyakov akosyakov mentioned this pull request Sep 25, 2017
Closed
@akosyakov akosyakov force-pushed the jb/extension_ui branch 9 times, most recently from d1120c6 to 6bda52b Compare October 2, 2017 12:53
@akosyakov akosyakov requested a review from svenefftinge October 2, 2017 13:09
@akosyakov
Copy link
Member Author

This PR is ready for the review. I am going to tackle outstanding issues from #391 (comment) separately.

@akosyakov
Copy link
Member Author

The history looks bogus in the PR, you better to look at commits in the branch.

@akosyakov akosyakov force-pushed the jb/extension_ui branch 7 times, most recently from 7ac91be to 75c708c Compare October 3, 2017 11:07
jbicker and others added 22 commits October 12, 2017 10:16
@jbicker @akosyakov
First rendering of extensions
4066ecb 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
Connected to server and edited styles
6bd4c5c 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
Added search, update, install, uninstall functionality
8417b06 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
Styling improved
ae99101 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
First steps to extension detail widget
4334324 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
Implemented extension detail service and widget.
bc54e81 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
Some improvements
af53c4b 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
Resolve extension data for detail page
d17028b 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
Merge
d9bb6b0 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@akosyakov
[extension-manager] ask user to reload after the successful installation
bedd70b 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@jbicker @akosyakov
Synchronization between sidebar and detail page.
c7aea3e 
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@jbicker @akosyakov
[extension manager] Refactored frontend and backend related to event …
7f73cdd 
…handling and synchronisation between extension list and detail view

Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
@akosyakov
[extension-manager] preserve extension widgets between sessions
55299a7 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
[extension-manager] updated README
e1f281a 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
[extension-manager] GH-369: support transitive dependencies
698c2e6 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
[application-package] resolve modules in the application context
46b760f 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@svenefftinge @akosyakov
[extension] Use widget-manager for the extension widget
9f40bf8 
Also some CSS changes and minor improvements.

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
@akosyakov
default port/host should be different for electron
bfcc09b 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
[extension-manager] notify a user on the installation start and failure
ecc2ec6 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
[extension-ui] disable transitive extensions
aaae38a 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
[extension-ui] filter out transitive extensions if the search query i…
b228d92 
…s empty

Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@akosyakov
[extension-ui] prefer published README to local
80707c6 
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
@hexa00
Copy link

hexa00 commented Oct 12, 2017

No objection from me, please merge.

BTW however does this change the debug process ? with the cluster etc ?

Would we need to update the Developing.md ?

@akosyakov
Copy link
Member Author

BTW however does this change the debug process ? with the cluster etc ?

Clustering is disabled for debugging.

Would we need to update the Developing.md ?

No, should be as before.

@akosyakov akosyakov merged commit ad1c4ad into master Oct 12, 2017
@akosyakov akosyakov deleted the jb/extension_ui branch October 12, 2017 12:34
@akosyakov akosyakov mentioned this pull request Oct 12, 2017
Closed
@svenefftinge svenefftinge mentioned this pull request Oct 18, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos left review comments

@svenefftinge svenefftinge svenefftinge approved these changes

@hexa00 hexa00 hexa00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akosyakov @svenefftinge @hexa00 @kittaakos @jbicker