[storage-service] applied feedback from #525 #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexa00
reviewed
Sep 21, 2017
| return this.storageService.getData(fullKey, defaultValue); | ||
| } | ||
|
|
||
| protected getKey(originalKey: string): string { | ||
| protected getPrefix(originalKey: string): string { |
There was a problem hiding this comment.
Nit but this one is called getPrefix and the other prefix
Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
svenefftinge
force-pushed
the
storage_feedback
branch
from
e18fb75 to
8ff533f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sven Efftinge sven.efftinge@typefox.io