fix: remove private backend service #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
changed the title
moved consumer EDR controller to runtime module
wolf4ood
reviewed
Apr 3, 2023
edc-tests/cucumber/src/test/java/org/eclipse/tractusx/edc/tests/HttpProxyTransferSteps.java
Show resolved
Hide resolved
wolf4ood
approved these changes
Apr 3, 2023
stephanbcbauer
approved these changes
Apr 3, 2023
4 tasks
paullatzelsperger
pushed a commit
to paullatzelsperger/tractusx-edc
that referenced
this pull request
May 4, 2023
…e/remove_private_backendservice fix: remove private backend service
paullatzelsperger
pushed a commit
that referenced
this pull request
May 4, 2023
…_backendservice fix: remove private backend service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This PR removes the private service image, that was used until now, from the business-test helm charts. In the business tests it was replaced with a Mock.
It also replaces/amends the corresponding Cucumber test with an equivalent JVM-based test.
WHY
We should not have code in an Eclipse project, that is not covered by either Eclipse, or an appropriate license, or that we have no control over.
Also, the corresponding Cucumber test (
HttpProxyTransferSteps) didn't really test anything of value, so going forward, all test maintenance must happen in theHttpConsumerPullWithProxyTest.Note: a similar test already exists in upstream EDC, but was replicated here for the sake of not losing test coverage.
FURTHER NOTES
This new test verifies, that access to a private backend can be granted through the data plane's HTTP proxy feature, where the consumer pulls the data.
Specifically:
mockwebserver)