Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a NPM Launch Configuration #340

Closed
mickaelistria opened this issue Feb 7, 2020 · 8 comments
Closed

a NPM Launch Configuration #340

mickaelistria opened this issue Feb 7, 2020 · 8 comments
Assignees

Comments

@mickaelistria
Copy link
Contributor

On a package.json, one should be able to do "Run As > npm update" (or whichever operation makes sense.

@AObuchow
Copy link
Contributor

AObuchow commented Feb 7, 2020

This is a really good idea!! It would make setting up ESLint in Wild Web Developer much easier, as one could install the dependencies from a package.json without using a terminal.

@AObuchow AObuchow self-assigned this Feb 7, 2020
@AObuchow
Copy link
Contributor

AObuchow commented Feb 7, 2020

@jabby What npm operation do you think is most useful? I tried comparing npm update and npm install by reading this but I'm still not sure. Perhaps having both is ideal?

@jabby
Copy link
Contributor

jabby commented Feb 7, 2020

My personal feeling is "There is no operation that are useful with Run as > packageManager operation".

All JS developers I know use and love cli for their build tools. Me too 😄 .

By the way, this issue is about npm but what about yarn or pnpm users?
If we want to support all main JS package managers, the Run as menu will explode some way.

@jabby
Copy link
Contributor

jabby commented Feb 7, 2020

FYI I found the following gerrit patches on wtp. Maybe there is something useful.

AObuchow added a commit to AObuchow/wildwebdeveloper that referenced this issue Feb 7, 2020
Fix eclipse-wildwebdeveloper#340

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit to AObuchow/wildwebdeveloper that referenced this issue Feb 7, 2020
Fix eclipse-wildwebdeveloper#340

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit to AObuchow/wildwebdeveloper that referenced this issue Feb 7, 2020
Fix eclipse-wildwebdeveloper#340

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@AObuchow
Copy link
Contributor

AObuchow commented Feb 7, 2020

@jabby Good point - I like CLI tools as well ;) However in this case, it's a necessary feature to add since it was available in JSDT (which is planned for removal).

In the end, I worked on a npm install shortcut. However, you have a good point about supporting multiple JS package managers... Maybe they should all be grouped under one launch configuration tab which allows the user to specify their desired package manager and the command to run?

@AObuchow
Copy link
Contributor

AObuchow commented Feb 7, 2020

FYI I found the following gerrit patches on wtp. Maybe there is something useful.

Thanks for these!

@mickaelistria
Copy link
Contributor Author

@jabby and in CLI, do you use more npm install or npm update.
Once we have launch configuration, they can then be used as build actions, so for example user can more easily hook auto update of dependencies on change in package.json.
About yarn and others, we'll see. My current impression with the node projects I've worked on (vscode and some language servers) is that even when yarn is in involved, there are some npm tasks wrapping it. So npm is kind of master.
About usage, typical Java developers using Eclipse IDE will most likely look for a Run As action. I think there is a population that will prefer it over CLI (I'm among them)

AObuchow added a commit to AObuchow/wildwebdeveloper that referenced this issue Feb 10, 2020
Fix eclipse-wildwebdeveloper#340

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
@jabby
Copy link
Contributor

jabby commented Feb 11, 2020

When I use npm I think I use more npm install but to be fair. I did only this one time without parameters.
Then if someone else add a new dependency, I use npm ci. This is the only way to have exactly the same dependencies than my coworkers.

If I add new dependencies I will again use npm install but this time with parameters (all libraries I want to install or upgrade to a new major version of a dependency).

By the way, I mostly use yarn now because I think install / update processes and lock file are better than the ones from npm.

AObuchow added a commit to AObuchow/wildwebdeveloper that referenced this issue Feb 11, 2020
Fix eclipse-wildwebdeveloper#340

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit to AObuchow/wildwebdeveloper that referenced this issue Feb 11, 2020
Fix eclipse-wildwebdeveloper#340

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit to AObuchow/wildwebdeveloper that referenced this issue Feb 11, 2020
Fix eclipse-wildwebdeveloper#340

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow added a commit to AObuchow/wildwebdeveloper that referenced this issue Feb 12, 2020
Fix eclipse-wildwebdeveloper#340

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants