Fix version macro & config deserialisation. #1601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of small fixes.
Nothing severe.
There's two changes here:
re-export
git_version
, this lets us use it in the macro, meaning downstream crates don't have to pull in a whole new crate just for the macro.Fix number reading via
ModeDependentValue
.I don't honestly know how I was hitting this path, I suspect it has something to do with the arbitrary precision feature, but I'll admit that I didn't look too deeply into it.
This change just accepts
u64
s as well, and then casts it to a signed number.I can split it into two PRs if needed, but I thought I'd just cut down on the noise.