Hotfix: Lower grading_period_name in surrogate key
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlittle08
approved these changes
Oct 21, 2024
rlittle08
deleted the
hotfix/lower_grading_period_name_in_surrogate_key
branch
gnguyen87
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Update stg_ef3__grading_periods.sql * Update CHANGELOG.md * Update dbt_project.yml --------- Co-authored-by: rlittle08 <rlittle@edanalytics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix: Lower
grading_period_namein Surrogate KeyDescription & motivation
The
edu_edfi_source.gen_skey()macro uses a helpergen_key_list()macro that lowercases columns before concatting them into a surrogate key. This leads to a discrepancy in logic between grades and grading_periods that causes joins between them to fail.Note that this appears to be a parallel issue to one that was solved in hotfix 0.4.1.
PR Merge Priority:
This is a critical fix for Podium dashboards in South Carolina for the 2025 school year.
Changes to existing files:
stg_ef3__grading_periods: Wrapgrading_period_namein alower()call to align withgen_skey()macro.Tests and QC done:
Queries have been run by hand in Snowflake that appears to resolve the join-issue when lowercasing this column.