Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes failed dirty check for non-english git #29

Merged
merged 2 commits into from
Feb 16, 2016

Conversation

cybernetlab
Copy link
Contributor

Hi! For non-english locales git status command responds with text that doesn't inclulde nothing to commit string. As a result repo seems as dirty for your task. git manpage (man git status) points me to --porcelain option that gives output for scripts and if there are nothing to commit it gives an empty string.

Example of git status output for russian locale:

$ git status
В ветке master
Your branch is up-to-date with 'origin/master'.

нечего фиксировать, рабочая директория пуста

Regards!

@rmm5t
Copy link
Member

rmm5t commented Feb 16, 2016

Thanks for this submission. Looks good.

I'm working on getting my collaborator access reinstated on this project (it moved owners at some point), but in the meantime, if you can fix this branch to avoid the version bump, that would be helpful. It will make it easier to pull in once I get the commit bit back. As an aside, it's usually best never to bump a version as part of a pull-request unless the pull-request is specifically about versioning.

@cybernetlab
Copy link
Contributor Author

Ok - I'll just remove changes in version.rb file. Is it right now?

@rmm5t
Copy link
Member

rmm5t commented Feb 16, 2016

@cybernetlab Yes, that'll do. Squashing the two commits into one would be better, but that'll require an interactive rebase and force push on your end. Depending on your level of comfort with git, don't sweat it.

@rmm5t rmm5t merged commit a15f988 into edgecase:master Feb 16, 2016
@rmm5t
Copy link
Member

rmm5t commented Feb 16, 2016

Loving it. Thanks! 🍻

@cybernetlab
Copy link
Contributor Author

;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants