Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Support for Whistle fingering #12

Merged
merged 7 commits into from
Jan 19, 2020
Merged

Conversation

eduardomourar
Copy link
Owner

This is the implementation for #9 and it depends on Fiati font v0.301

@jgadsden
Copy link
Contributor

jgadsden commented Jan 19, 2020

Hello @eduardomourar - generally looking excellent, thankyou, but with one bug that is easily fixed. This is an edge case, but when more than one whistle staff is included in the score then the D Tin Whistle Staff will use whatever 'transpose' is currently set - which is '0' initially, but if a staff for a tin whistle has already been processed with a 'transpose' value different to 0 (say 2 for a C Tin Whistle) then the D Tin Whistle staff fingering will use this 'transpose' value instead of the correct value of '0'.

Suggest that the if statement from line 386 of fingeringdiagram.qml could explicitly set 'transpose' for D tin whistles.

To test this, construct MuseScore score with 3 staves in order 'D Tin Whistle', 'C Tin Whistle' and 'D Tin Whistle'. Apply fingeringdiagram.qml plugin and observe first two staves are correct, but 3rd staff has C tuning not the expected D tuning.
Alternatively this can be observed when using plugin for the score https://github.com/jgadsden/tin-whistle-tablature/tree/master/examples/tin_whistle_test.mscz

@eduardomourar eduardomourar merged commit 2b113b6 into master Jan 19, 2020
@eduardomourar eduardomourar deleted the feature/add-whistles branch January 19, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants