Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log errors caused by BW printers #57 #65

Closed
wants to merge 2 commits into from

Conversation

tagno25
Copy link

@tagno25 tagno25 commented Aug 18, 2020

This seems to have fixed #57 and still behaves correctly when data_item is None

@elad-bar
Copy link
Owner

elad-bar commented Oct 1, 2020

@tagno25 not sure what you tried to achieve?
can you pleasesend the XML examples of your printer?
if you know the code is about to fall from the specific exception, why not to pre-handle it?

thanks

@tagno25
Copy link
Author

tagno25 commented Oct 4, 2020

I was trying to get rid of the massive number of errors in the logs caused by black and white only printers.

Here are the XML files for my printer.
https://gist.github.com/tagno25/0b9071c6c90110282e1eec7af9fb7ca2

@SaifAqqad
Copy link

Will this ever be merged?
BW-only printers still don't work to this day 😕

@elad-bar
Copy link
Owner

thanks for assisting

I will get to it next weekend, I need to test it with different type of printer to make sure it will not impact them,
It worked originally very similiar to that and I changed it because of issue caused from that, will get back to you

@elad-bar
Copy link
Owner

not relevant

@elad-bar elad-bar closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log is filling with errors
3 participants