Smooth By Normals #776
Merged
Smooth By Normals #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mm, this look interesting, could you add a screenshot or two ? |
|
This is still WIP, even once I merge this. I still need to add quad support, as right now it's still pretty ugly. |
|
Will take a bit of time for me to review this, I have a hundred assignments to grade, probably will review this weekend. |
elalish
commented
Mar 26, 2024
| template <typename T> | ||
| void ForVert(int halfedge, std::function<T(int halfedge)> transform, | ||
| std::function<void(int halfedge, const T& here, const T& next)> | ||
| binaryOp) { |
There was a problem hiding this comment.
@pca006132 Don't worry about a serious review - I was mostly curious if you thought this was a reasonable way to handle #775.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #771, that allows smoothing based on input normal properties. Has the convenient side effect of making a solid test since we now have two different paths to create the same type of smoothing, in the case of sharp edges.
I also added
ForVert, which I think is a good start toward addressing #775.