Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix glm install #782

Merged
merged 4 commits into from
Mar 30, 2024
Merged

fix glm install #782

merged 4 commits into from
Mar 30, 2024

Conversation

pca006132
Copy link
Collaborator

Fixes #777

Verified

This commit was signed with the committer’s verified signature.
mjcheetham Matthew John Cheetham
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (d437097) to head (367c90c).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   91.84%   88.34%   -3.50%     
==========================================
  Files          37       55      +18     
  Lines        4976     7936    +2960     
  Branches        0      866     +866     
==========================================
+ Hits         4570     7011    +2441     
- Misses        406      925     +519     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elalish
Copy link
Owner

elalish commented Mar 29, 2024

Huh, well now the CI is reproducing exactly the error from the issue on Mac. Go figure.

@pca006132
Copy link
Collaborator Author

Hmm, probably know what is happening her. The main problem is that we are using glm but it is not in our exported targets. But putting it in our exported target will make cmake complain as well. My previous "fix" is removing it from our install interface, but in that case probably the header path is messed up when using our library.

Anyway, will try to fix.

@pca006132
Copy link
Collaborator Author

I need to check if the glm installation works on ubuntu as well, will do tmr.

@pca006132 pca006132 merged commit 7872959 into elalish:master Mar 30, 2024
18 checks passed
@pca006132 pca006132 deleted the fix-glm-install branch March 30, 2024 05:27
@elalish elalish mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants