Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set import library for Clipper2 target when using system version #815

Merged
merged 1 commit into from
May 21, 2024

Conversation

imciner2
Copy link
Contributor

On Windows, the import library is also needed to link against the Clipper2 DLL, and that must be specified using a different target property.

We noticed this when building manifold in Julia on Windows: JuliaPackaging/Yggdrasil#8712 (comment)

On Windows, the import library is also needed to link against the
Clipper2 DLL, and that must be specified using a different target
property.
Copy link

google-cla bot commented May 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.27%. Comparing base (d437097) to head (8fdf5b5).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   91.84%   89.27%   -2.57%     
==========================================
  Files          37       61      +24     
  Lines        4976     8439    +3463     
  Branches        0      927     +927     
==========================================
+ Hits         4570     7534    +2964     
- Misses        406      905     +499     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elalish elalish merged commit 5ef09da into elalish:master May 21, 2024
18 checks passed
@elalish elalish mentioned this pull request Jun 12, 2024
@imciner2 imciner2 deleted the im/importlib branch June 13, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants