-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify lint and format nox sessions #2790
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-2790-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4d5060ba2626d8495892b556a4f0b3992063ba73
# Push it to GitHub
git push --set-upstream origin backport-2790-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
(cherry picked from commit 4d5060b)
(cherry picked from commit 4d5060b)
(cherry picked from commit 4d5060b) # Conflicts: # noxfile.py
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
As agreed offline, we stop calling lint() from format(). And I also reduced the number of mypy invocations - separating calls makes no difference.