Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lint and format nox sessions #2790

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

pquentin
Copy link
Member

As agreed offline, we stop calling lint() from format(). And I also reduced the number of mypy invocations - separating calls makes no difference.

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@pquentin pquentin merged commit 4d5060b into elastic:main Feb 12, 2025
17 checks passed
Copy link

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-2790-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4d5060ba2626d8495892b556a4f0b3992063ba73
# Push it to GitHub
git push --set-upstream origin backport-2790-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-2790-to-8.17.

github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
pquentin added a commit that referenced this pull request Feb 12, 2025
(cherry picked from commit 4d5060b)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit to pquentin/elasticsearch-py that referenced this pull request Feb 12, 2025
(cherry picked from commit 4d5060b)

# Conflicts:
#	noxfile.py
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Feb 12, 2025
* Simplify lint and format nox sessions (#2790)

(cherry picked from commit 4d5060b)

# Conflicts:
#	noxfile.py

* Add missing error codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants