Change the maximum digits in a year to 4 #54260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed the default joda behaviour in strict_date_optional_time to max 4 digits in a year. This helps parsing epoch_millis format which is often used in a default format `strict_date_optional_time||epoch_millis` This change adjustes our java.time implmementation to behave the same way
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
|
Changing to 4 digit year seems ok to me, but I don't recall exactly why we allowed 10 digits in the first place. I vaguely remember this being joda behavior we were matching. @spinscale do you remember at all why we do the above? I'm also unsure to what extent we can make this change in 7.x, since it is technically breaking? I think we would need a proper deprecation period and possibly a flag so users can opt in to the newer behavior. |
|
ok to test |
|
closing in favour of #73034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the default joda behaviour in strict_date_optional_time to
max 4 digits in a year. This helps parsing epoch_millis format which is
often used in a default format
strict_date_optional_time||epoch_millisThis change adjustes our java.time implmementation to behave the same
way
closes #52396