Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change year max digits for strict_date_optional_time and date_optional_time backports(#73034) #73750

Merged

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jun 4, 2021

We changed the default joda behaviour in strict_date_optional_time to
max 4 digits in a year. Java.time implementation should behave the same way.
At the same time date_optional_time should have 9digits for year part.

closes #52396
closes #72191
backports #73034

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

Unverified

This user has not yet uploaded their public signing key.
…l_time (elastic#73034)

We changed the default joda behaviour in strict_date_optional_time to
max 4 digits in a year. Java.time implementation should behave the same way.
At the same time date_optional_time should have 9digits for year part.

closes elastic#52396
closes elastic#72191
@pgomulka pgomulka added :Core/Infra/Core Core issues without another label backport labels Jun 4, 2021
@pgomulka pgomulka self-assigned this Jun 4, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Unverified

This user has not yet uploaded their public signing key.
@pgomulka pgomulka merged commit fb2361b into elastic:7.x Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants