Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log 'output of node' separators to stdout #87736

Conversation

DaveCTurner
Copy link
Contributor

Today when using Gradle-managed test clusters we separate the log output
from each node with a separator that looks like this:

=== Log output of node `node{:qa:mixed-cluster:v8.2.0-0}` ===

However, we write this to stderr and yet write the rest of the log
output to stdout. This commit moves the separators to the same log
level as the rest of this output so that they can all be redirected to
the same place.

Today when using Gradle-managed test clusters we separate the log output
from each node with a separator that looks like this:

    === Log output of node `node{:qa:mixed-cluster:v8.2.0-0}` ===

However, we write this to `stderr` and yet write the rest of the log
output to `stdout`. This commit moves the separators to the same log
level as the rest of this output so that they can all be redirected to
the same place.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure v8.4.0 labels Jun 16, 2022
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Jun 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 16, 2022
@elasticsearchmachine elasticsearchmachine merged commit b9f8025 into elastic:master Jun 16, 2022
@DaveCTurner DaveCTurner deleted the 2022-06-16-log-separator-to-stdout branch June 16, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants