Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to vis_types folder part 3 #112084

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Move to vis_types folder part 3 #112084

merged 3 commits into from
Sep 15, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 14, 2021 •
edited
Loading

Summary

Part of #107500

This is the second part of moving all the vis_type_* plugins to a new folder vis_types.

In this PR two plugins are moved:

table
timelion

Changes in details are:

  • Moved the vis_type_table and vis_type_timelion to the vis_types folder.
  • Remove the vis_type_ from the folder name. From now on they will be table, timelion. Important note: Only the folder names have changed and not the plugin ids.
  • All the relative paths have been updated
  • Updated all the kibana conf files (jest, tsconfig) to take under consideration the new paths

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 labels Sep 14, 2021
@stratoula stratoula marked this pull request as ready for review September 14, 2021 17:46
@stratoula stratoula requested review from a team as code owners September 14, 2021 17:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

ryankeairns
ryankeairns approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scss files moved

mbondyra
mbondyra approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Opened and tested on Chrome and nothing seems to breaking.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit e20f530 into elastic:master Sep 15, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Sep 15, 2021
@stratoula
Move to vis_types folder part 3 (elastic#112084)
55aa6c3 
* Move to vis_types folder part 3

* Fix jest tests
# Conflicts:
#	.github/CODEOWNERS
#	.i18nrc.json
#	api_docs/data.json
#	api_docs/vis_type_timelion.json
@stratoula stratoula mentioned this pull request Sep 15, 2021
Merged
stratoula added a commit that referenced this pull request Sep 15, 2021
@stratoula
Move to vis_types folder part 3 (#112084) (#112243)
40e0ce8 
* Move to vis_types folder part 3

* Fix jest tests
# Conflicts:
#	.github/CODEOWNERS
#	.i18nrc.json
#	api_docs/data.json
#	api_docs/vis_type_timelion.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@jbudz jbudz jbudz approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stratoula @elasticmachine @kibanamachine @ryankeairns @jbudz @mbondyra